Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo caching feature #4554

Merged
merged 11 commits into from
Nov 29, 2023
Merged

Repo caching feature #4554

merged 11 commits into from
Nov 29, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 29, 2023 •
edited
Loading

What are you changing in this pull request and why?

Document the new repo caching option in dbt Cloud

Checklist

Adding new pages (delete if not applicable):

  • [ ] Add page to website/sidebars.js automated for release notes
  • Provide a unique filename for the new page

@nghi-ly nghi-ly requested a review from a team as a code owner November 29, 2023 19:37
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 10:36pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Nov 29, 2023
@nghi-ly nghi-ly requested a review from thorn14 November 29, 2023 19:39
joellabes
joellabes requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome! Couple of nitpicks and requests for more depth

website/docs/docs/dbt-versions/release-notes/02-Nov-2023/repo-caching-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/repo-caching-rn.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
@nghi-ly nghi-ly requested review from thorn14 and joellabes November 29, 2023 20:46
joellabes
joellabes approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

runleonarun
runleonarun approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghi-ly Looks great! I just have a tiny wording suggestion.

website/docs/docs/dbt-versions/release-notes/02-Nov-2023/repo-caching.md Outdated Show resolved Hide resolved
@nghi-ly nghi-ly enabled auto-merge November 29, 2023 22:29
@nghi-ly nghi-ly merged commit f484d26 into current Nov 29, 2023
7 checks passed
@nghi-ly nghi-ly deleted the ly-docs-repo-caching branch November 29, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn14 thorn14 thorn14 approved these changes

@joellabes joellabes joellabes approved these changes

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nghi-ly @runleonarun @joellabes @thorn14